Unify void elements style #10644
Merged
Unify void elements style #10644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 26, 2017
|
The CI has currently an issue, PR for which is #10645. |
|
@robinpokorny: Can you rebase after the docs link fix? |
robinpokorny
force-pushed
the
unify-void-elements-style
branch
from
ffe5eff
to
320fb28
Compare
|
@jridgewell, done 😄 |
jridgewell
approved these changes
Jul 31, 2017
|
Hi, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the spec, examples, and docs the style of void elements in
<head>is inconsistent. I noticed it first for<link rel="canonical" …>in the tutorial, which includes/compared to<meta>s around it. A quick look at other places showed me that the style without/is prevailing.This PR removes the closing slash for all
<link>and<meta>elements.<link (.+) ?/>resp.<meta (.+) ?/>, with<link $1>resp.<meta $1>.Sibling PR in ampproject/docs: ampproject/amp.dev#632