New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mocha, karma, and all related deps to their latest versions #12499
Conversation
/to @erwinmombay @choumx |
return ampAd.implementation_.upgradeCallback().then(() => { | ||
done(); | ||
}); | ||
return ampAd.implementation_.upgradeCallback(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So is the new best practice just to return Promises and no longer to use done? Or does it not matter so long as it's consistent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh nvm. It doesn't matter so long as you're consistent. This change is just because this throws an exception now. Sorry--should have clicked through to the attached links.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. If you're returning a Promise, the call to done()
used to be ignored, but it now flags an error.
This PR does the following:
mocha
,karma
, all their dependencies, and related tools to their latest versions.connectOptions
(which contained a hard-coded port number) fromkarma.conf.js
(See Tests not working on Sauce Labs karma-runner/karma-sauce-launcher#145 (comment))List of packages updated:
Partial fix for #12181