New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all of AMP's CSS devDependencies to their latest versions #12512
Conversation
/to @erwinmombay This is as discussed in #12472 (comment) |
@erwinmombay This PR passes Travis checks. Let me know if there's any documentation for the golden file check, and I can run it tomorrow. |
CSS golden file check coming up in #12526. |
@erwinmombay I tested the latest changes with Merging this after tests go green. |
@camelburrito @erwinmombay After this PR is merged, it's probably worth updating our Full list of available packages here: https://github.com/ben-eb/cssnano/tree/master/packages |
This PR does the following:
yarn add autoprefixer cssnano postcss postcss-import --dev --exact --latest
cssnano
from v3.10.0 to v4.0.0-rc.2 to get past a deprecation warning forNode#moveTo
. (See ben-eb/postcss-merge-rules#52)build-system/tasks/create-golden-css/index.js
andbuild-system/tasks/jsify-css.js
to be compliant withcssnano
v4, with minimum deviations from the CSS generated pre-upgrade.This can be followed up with a PR that updates our
cssnano
settings and uses some of the new optimization features in v4.Follow up to #12179, #12450, #12476, #12486, and #12499
Partial fix for #12181