Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lightbox icons #13074

Merged
merged 1 commit into from Jan 26, 2018
Merged

Conversation

cathyxz
Copy link
Contributor

@cathyxz cathyxz commented Jan 26, 2018

Update lightbox icons per latest designs.

@cathyxz cathyxz merged commit 3102d9d into ampproject:master Jan 26, 2018
jonkeller pushed a commit to jonkeller/amphtml that referenced this pull request Jan 29, 2018
@cvializ
Copy link
Contributor

cvializ commented Jan 29, 2018

Out of curiosity, where did the new icon svgs come from? They aren't optimized so they still have ids in them. We have an optimization step in the build, but here they are still superfluous.

@aghassemi
Copy link
Contributor

@cvializ Excellent catch on ids, /to @cathyxz to remove them

@cathyxz
Copy link
Contributor Author

cathyxz commented Jan 29, 2018

Ack. @cvializ they came from a design team. =) The designer exported them from Sketch.

@cathyxz cathyxz deleted the feature/lightbox-icons branch January 29, 2018 19:43
RanAbram pushed a commit to RanAbram/amphtml that referenced this pull request Mar 12, 2018
protonate pushed a commit to protonate/amphtml that referenced this pull request Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants