Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightbox: Remove icon ids from svgs #13123

Merged
merged 1 commit into from Jan 30, 2018

Conversation

cathyxz
Copy link
Contributor

@cathyxz cathyxz commented Jan 29, 2018

Per discussion in #13074

Copy link
Contributor

@cvializ cvializ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@cvializ cvializ merged commit a524c76 into ampproject:master Jan 30, 2018
@cathyxz cathyxz deleted the bugfix/lightbox-icons branch January 30, 2018 22:56
gzgogo pushed a commit to gzgogo/amphtml that referenced this pull request Feb 14, 2018
gzgogo pushed a commit to gzgogo/amphtml that referenced this pull request Feb 14, 2018
gzgogo pushed a commit to gzgogo/amphtml that referenced this pull request Feb 14, 2018
RanAbram pushed a commit to RanAbram/amphtml that referenced this pull request Mar 12, 2018
protonate pushed a commit to protonate/amphtml that referenced this pull request Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants