Make sure node_modules/web-animations-js is patched after gulp update-packages
#13199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/to @jridgewell |
rsimha
changed the title
gulp update-packages
lannka
approved these changes
Feb 1, 2018
This was referenced Feb 1, 2018
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
protonate
pushed a commit
to protonate/amphtml
that referenced
this pull request
Mar 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #6189, @dvoytenko added a function
patchWebAnimations()togulpfile.js, which writes the filenode_modules/web-animations-js/web-animations.install.js. However, this function was being called in the global scope ofgulpfile.js, and would therefore run before anygulptask was executed.This poses a problem when
gulp update-packagesis run as a prerequisite togulp, and happens to updatenode_modules, sinceweb-animations.install.jsis patched beforenode_modules/web-animations-jsis potentially overwritten byyarn.This PR eliminates the problem by moving the call to
patchWebAnimations()from the global scope ofgulpfile.jsto just before the extensions are built as part of the gulp build process.Fixes #13177