-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new gulp task for patchWebAnimations #13238
Conversation
/to @choumx Tested locally by deleting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does dep-check run compileCss()
? I don't see the reference in dep-check.js.
It does, via a dependency expressed in https://github.com/ampproject/amphtml/blob/master/build-system/tasks/dep-check.js#L300 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks. Might be more readable to import patchWebAnimations
directly into dep-check? I think web animations semantically are not related to CSS.
Good point. I've moved the function into its own |
/cc @erwinmombay FYI |
#13199 moved the call to
patchWebAnimations()
from the global scope ingulpfile.js
toperformBuild()
, which is called bybuild()
andwatch()
. Then, #13221 added a call todist()
. Turns out we need the call ingulp dep-check
as well.This PR adds a new
gulp patch-web-animations
task that's used as a prerequisite forgulp
,gulp build
,gulp watch
,gulp dist
, andgulp dep-check
See https://travis-ci.org/ampproject/amphtml/jobs/336675870#L1736 for the failure case.
Follow up to #13199 and #13221
Fixes #13177
Partial fix for #13227