Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃彈 Be a little more lenient with Unused Private Linting #14807

Merged
merged 4 commits into from Apr 24, 2018

Conversation

jridgewell
Copy link
Contributor

Examples can do whatever, and we only want to report fields on this.

Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the message need to be reworded due to this change?

@jridgewell
Copy link
Contributor Author

Nah, I wrote the message with this as the intended linting, just forgot to add the this check.

@jridgewell jridgewell merged commit a5a9cf7 into ampproject:master Apr 24, 2018
@jridgewell jridgewell deleted the unused-private-cleanup branch April 24, 2018 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants