AdSense/Doubleclick Fast Fetch - setup delay request by viewport experiments #16136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradfrizzell
approved these changes
Jun 19, 2018
| addExperimentIdToElement(adsenseFormatExpId, this.element); | ||
|
|
||
| this.size_ = adsenseFormatExpId == '21062004' | ||
| this.size_ = getExperimentBranch(this.win, FORMAT_EXP) == '21062004' |
There was a problem hiding this comment.
I realize you didn't name this attribute in this PR, but this seems like a bad name if it is a bool....
| @@ -234,6 +257,27 @@ export class AmpAdNetworkAdsenseImpl extends AmpA4A { | |||
| return null; | |||
| } | |||
|
|
|||
| /** @visibleForTesting */ | |||
| divertExperiments() { | |||
There was a problem hiding this comment.
could probably use a little more jsdoc or inline comments explaining what the experiments are
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add experiments for AdSense & Doubleclick Fast Fetch that delays sending ad request depending on slots location relative to viewport (see infrastructure added in #15989). For AdSense, experiment includes multiple viewport ranges (3, 4, 6, 12 viewports) and for Doubleclick add experiment that delays until within 12 viewports if using render on idle.