AdSense/Doubleclick remove delay request experiments #16623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradfrizzell
reviewed
Jul 9, 2018
| * @visibleForTesting | ||
| */ | ||
| export const DELAY_REQUEST_EXP_BRANCHES = { | ||
| '21062224': true, // control, delay by renderOutsideViewport |
There was a problem hiding this comment.
Please remove all server side references to these experiments.
| @@ -301,12 +288,6 @@ export class AmpAdNetworkDoubleclickImpl extends AmpA4A { | |||
| return this.isAmpAdElement(); | |||
| } | |||
|
|
|||
| /** @override */ | |||
| delayAdRequestEnabled() { | |||
| return getExperimentBranch(this.win, RENDER_IDLE_DELAY_REQUEST_EXP) == | |||
There was a problem hiding this comment.
Just want to doublecheck that the intent here is to fully delete, as opposed to in the adsense impl where it just returns true
bradfrizzell
approved these changes
Jul 9, 2018
Codecov Report
@@ Coverage Diff @@
## master #16623 +/- ##
==========================================
+ Coverage 77.11% 78.1% +0.98%
==========================================
Files 550 551 +1
Lines 40274 40362 +88
==========================================
+ Hits 31059 31523 +464
+ Misses 9215 8839 -376
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in #16136 and being removed as unlaunchable