Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead links in amp-access-analytics doc #19588

Merged
merged 2 commits into from Dec 10, 2018
Merged

Remove dead links in amp-access-analytics doc #19588

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70f7a8d
Remove dead links in amp-access-analytics doc
Dec 3, 2018
a8e7ab2
Fix link to amp-var-substitutions doc
Dec 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions extensions/amp-access/amp-access-analytics.md
View file
Open in desktop
Expand Up @@ -91,7 +91,7 @@ The `access-pingback-failed` event is issued when the Pingback endpoint has fail

The `access-login[-type]-started` event is issued right before the Login dialog has been opened. Use these configurations to fire a request for this event.

When only one Login URL is configured, the event is `access-login-started`. When multiple Login URLs are configured, the event is `access-login-type-started`, e.g. "access-login-signup-started". See [Login Page Spec](./amp-access-spec.md#login-page) for more info.
When only one Login URL is configured, the event is `access-login-started`. When multiple Login URLs are configured, the event is `access-login-type-started`, e.g. "access-login-signup-started".

```javascript
"triggers": {
Expand All @@ -106,7 +106,7 @@ When only one Login URL is configured, the event is `access-login-started`. When

The `access-login[-type]-success` event is issued when Login dialog has succeeded. Use these configurations to fire a request for this event.

When only one Login URL is configured, the event is `access-login-success`. When multiple Login URLs are configured, the event is `access-login-type-success`, e.g. "access-login-signup-success". See [Login Page Spec](./amp-access-spec.md#login-page) for more info.
When only one Login URL is configured, the event is `access-login-success`. When multiple Login URLs are configured, the event is `access-login-type-success`, e.g. "access-login-signup-success".

```javascript
"triggers": {
Expand All @@ -121,7 +121,7 @@ When only one Login URL is configured, the event is `access-login-success`. When

The `access-login[-type]-rejected` event is issued when Login dialog has been rejected by the user. Use these configurations to fire a request for this event.

When only one Login URL is configured, the event is `access-login-rejected`. When multiple Login URLs are configured, the event is `access-login-type-rejected`, e.g. "access-login-signup-rejected". See [Login Page Spec](./amp-access-spec.md#login-page) for more info.
When only one Login URL is configured, the event is `access-login-rejected`. When multiple Login URLs are configured, the event is `access-login-type-rejected`, e.g. "access-login-signup-rejected".

```javascript
"triggers": {
Expand All @@ -136,7 +136,7 @@ When only one Login URL is configured, the event is `access-login-rejected`. Whe

The `access-login[-type]-failed` event is issued when Login dialog has failed due to an unknown reason. Use these configurations to fire a request for this event.

When only one Login URL is configured, the event is `access-login[-type]-failed`. When multiple Login URLs are configured, the event is `access-login-type-failed`, e.g. "access-login-signup-failed". See [Login Page Spec](./amp-access-spec.md#login-page) for more info.
When only one Login URL is configured, the event is `access-login[-type]-failed`. When multiple Login URLs are configured, the event is `access-login-type-failed`, e.g. "access-login-signup-failed".

```javascript
"triggers": {
Expand All @@ -149,7 +149,7 @@ When only one Login URL is configured, the event is `access-login[-type]-failed`

## Access analytics variables

Access contributes the following URL substitutions to the [amp-var-substitutions.md](/spec/amp-var-substitutions.md).
Access contributes the following URL substitutions to the [amp-var-substitutions.md](../../spec/amp-var-substitutions.md).

### ACCESS_READER_ID

Expand Down