Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the need for integration test for 3rd party integration #19668

Merged
merged 5 commits into from
Dec 7, 2018
Merged

Document the need for integration test for 3rd party integration #19668

merged 5 commits into from
Dec 7, 2018

Conversation

lannka
Copy link
Contributor

@lannka lannka commented Dec 5, 2018

Closes #13110

@lannka lannka requested a review from jeffjose December 6, 2018 18:25
mrjoro
mrjoro reviewed Dec 6, 2018
View reviewed changes
Copy link
Member

@mrjoro mrjoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding some documentation around this. I'll also add @rsimha to the review since it touches testing.

3p/README.md Outdated Show resolved Hide resolved
@mrjoro mrjoro requested a review from rsimha December 6, 2018 19:14
lannka
lannka commented Dec 7, 2018
View reviewed changes
Copy link
Contributor Author

@lannka lannka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

3p/README.md Outdated Show resolved Hide resolved
rsimha
rsimha approved these changes Dec 7, 2018
View reviewed changes
Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this!

mrjoro
mrjoro approved these changes Dec 7, 2018
View reviewed changes
Copy link
Member

@mrjoro mrjoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks!

@lannka lannka merged commit 7f6863f into ampproject:master Dec 7, 2018
@lannka lannka deleted the 3p-readme-integration-test branch December 7, 2018 22:57
noranazmy pushed a commit to noranazmy/amphtml that referenced this pull request Mar 22, 2019
@lannka
Document the need for integration test for 3rd party integration (am…
54fb8bc 
…pproject#19668)

* Document the need for integration test for 3rd party integration

* Document the need for integration test for 3rd party integration

* update

* Fix test

* Remove batch plugin doc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CrystalOnScript CrystalOnScript CrystalOnScript approved these changes

@mrjoro mrjoro mrjoro approved these changes

@rsimha rsimha rsimha approved these changes

@jeffjose jeffjose Awaiting requested review from jeffjose

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lannka @CrystalOnScript @mrjoro @rsimha @googlebot