Enforce no mix interpolation #19700
Merged
Enforce no mix interpolation #19700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
reviewed
Dec 7, 2018
|
@jridgewell do you mean for the whole codebase? The was the original plan. but now we want to allow template literals if the user wants to since we can generate the string format message ( |
|
No, I mean these corrected uses. If we're just gonna convert them in the transformer, why not convert them now? |
|
@jridgewell thats fair. will fix |
|
@jridgewell done |
erwinmombay
force-pushed
the
enforce-no-mix
branch
from
dd2718f
to
d7887dd
Compare
jridgewell
approved these changes
Dec 10, 2018
kristoferbaxter
approved these changes
Dec 11, 2018
erwinmombay
force-pushed
the
enforce-no-mix
branch
5 times, most recently
from
dbcc962
to
29e4701
Compare
Instead of outright banning non literal strings, we just want to make sure the user doesn't interleave template literal interpolation and strformat style interpolation as this makes the transformers job of tracking positioning harder.
erwinmombay
force-pushed
the
enforce-no-mix
branch
from
29e4701
to
15bb0b7
Compare
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* enforce no mixing of interpolation styles * refactor the no-non-string-log-args lint rule to no-mixed-interpolation Instead of outright banning non literal strings, we just want to make sure the user doesn't interleave template literal interpolation and strformat style interpolation as this makes the transformers job of tracking positioning harder. * switch to strformat the mixed call sites * skip failing test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of outright banning non literal strings, we just want to make sure the user doesn't interleave template literal interpolation and strformat style interpolation as this makes the transformers job of tracking positioning harder.