Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce no mix interpolation #19700

Merged
merged 4 commits into from Dec 20, 2018
Merged

Enforce no mix interpolation #19700

merged 4 commits into from Dec 20, 2018

Commits on Dec 20, 2018

  1. enforce no mixing of interpolation styles

    @erwinmombay
    erwinmombay committed Dec 20, 2018
    Copy the full SHA
    ff1c394 View commit details
    Browse the repository at this point in the history

  2. refactor the no-non-string-log-args lint rule to no-mixed-interpolation 

    Instead of outright banning non literal strings, we just want to make
sure the user doesn't interleave template literal interpolation and
strformat style interpolation as this makes the transformers job of
tracking positioning harder.
    @erwinmombay
    erwinmombay committed Dec 20, 2018
    Copy the full SHA
    54f6440 View commit details
    Browse the repository at this point in the history

  3. switch to strformat the mixed call sites

    @erwinmombay
    erwinmombay committed Dec 20, 2018
    Copy the full SHA
    3d5e049 View commit details
    Browse the repository at this point in the history

  4. skip failing test

    @erwinmombay
    erwinmombay committed Dec 20, 2018
    Copy the full SHA
    15bb0b7 View commit details
    Browse the repository at this point in the history