fix a4a intersection observer

[erwinmombay]

fixes #19623

[zhouyx]

@erwinmombay I have one question, instead of returning a JsonObject, can we keep the RefreshConfig defination, but have the convertAndSanitizeConfiguration_ returns an object like

{
  continousTimeMin: config['continuousTimeMin']*1000,
  ...
}

I don't feel that the namespace continousTimeMin and visiblePercentageMin is useful after the read. WDYT?

[erwinmombay]

im ok with that for the most part.

just a thought though, using refreshconfig here, somebody is going to get tripped up again i think at some point. having a typedef does not mean closure will preserve the key values, and "configurations" almost always crosses these boundaries (xhr, html, postmessage, iframe) and the other side is going to get garbled obfuscated keys.

[zhouyx]

somebody is going to get tripped up again i think at some point

I completely agree. I think this is a tradeoff between code size and style. Given this purely lives within extension code, I believe you're right to go with style.

i think at some point. having a typedef does not mean closure will preserve the key values

Thought typedef is more about type checking. If we move to JsonObject, is there a way to enforce type later?

[erwinmombay]

Thought typedef is more about type checking. If we move to JsonObject, is there a way to enforce type later?

This is why JsonObject should be used at the boundaries and types/typedefs everywhere else. unfortunately, its a little hard for me to interpret this much code so its easier for me to just JsonObject everything so that I don't make a mistake.

I completely agree. I think this is a tradeoff between code size and style. Given this purely lives within extension code, I believe you're right to go with style.

did you mean you are OK with what I did, or do you prefer that i try to keep the typedef's ?

[zhouyx]

Talked offline. We agreed it's safest to use JsonObject for extern config at this point. I'll need to figure something out in the future. A read/write method that handle externs, that could be difficult to enforce.

Anyhow this is something that needs further discussion. To fix the current issue, the PR looks good to me.