♻️ amp-viqeo-player: placeholder and refactoring #19885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kinoshnik2070
commented
Dec 14, 2018
•
kinoshnik2070
commented
- create placeholder
- refactoring
- create placeholder - remove autoplay attribute and add noautoplay - refactoring
|
This is considered a breaking change due to |
|
@kimhogeling per @honeybadgerdontcare comment and per AMP's autoplay policy, your video player should use AMP's builtin autoplay feature which is based on the opt-in |
aghassemi
reviewed
Dec 17, 2018
There was a problem hiding this comment.
@kinoshnik2070 Couple of small requests, we can merge after addressing them. Thank you
aghassemi
approved these changes
Dec 18, 2018
| placeholder.setAttribute('layout', 'fill'); | ||
| placeholder.setAttribute('placeholder', ''); | ||
| placeholder.setAttribute('referrerpolicy', 'origin'); | ||
| placeholder.setAttribute('alt', 'Loading video'); |
There was a problem hiding this comment.
this is overriding alt again, I will fix it and merge, no action needed from you.
|
@kinoshnik2070 merged. Thanks! |
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Dec 19, 2018
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.