12 #1
Merged
12 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Disallow URL bindings in amp4email. * Add bind-validator tests. * Add integration tests. * Fix tests.
* Fix element services and AMP.setState in FIE. * Reference GH issue. * Fix types. * Fix tests.
* Fixed misleading 'yarn' error about 'gulp' on first install * Fixed Lint issue with string 157:34 error Strings must use singlequote quotes * Made 'list directory' command compatible with windows as well. Added note about not importing node packages since they'll break 'yarn' on the first-install use case. * Changed note comment due to lint line length error * Update check-package-manager.js * Reverting to cleaner 'fs' implementation since 'existsSync' functionality it's available natively
* add analytics vendor keen.io * fix analytics lint for vendor keen * fix comment for Keen tracking example code * fix tests for keen analytics vendor * vendor keen analytics custom request test * fix custom test unhandled variable * fix test variable ending * use xhr transport if beacon API is not available
* Add DomElement type * Remove non-type/non-docs changes
* Added theme-color based on accent color for ampstory * Added theme-color based on accent color for ampstory * Updated JSDoc for method * fixed lint errors and test errors * fixed suggestions from code review * use computed style helper instead of getComputedStyle * fixed tests, implemented code review suggestions
…to amp-list for resizing (#19184) * Add containerize action * Add bindable attribute isContainer * Remove auto-container behavior * Update bindable attribute name * Update examples * Guard action registration behind experiment flag * Call changeToLayoutContainer in mutate context only * Rename functions and attributes correctly * Add integration tests for amp-list resize functions * Fix type check * Add comment about adding is-layout-container to validator file * Add documentation for changeToLayoutContainer * Fix gulp lint warnings on bind-impl * Add fall through comment * Update documentation for is-layout-container * Minor rename and testing fix * Add square brackets around is-layout-container
* cl/221331004 Simplify FORM. * cl/221678254 Relax attribute blacklisted_value_regex to only match values before urlescaping. * cl/221691892 Media query spec for amp4email. * cl/221808630 Revision bump for #18188 * cl/221824133 Remove validator support for the deprecated boilerplate CSS. * cl/222112581 Revision bump for #19285
* introduce consentInfoDef * fix tests address comments
…#19414) * Add DomElement type * Remove non-type/non-docs changes * Loosen MediaPool placeholder type from HTMLMediaElement to Element
add account linking log events
…layer and gridlayer (#19461)
#19465) * remove gen-codeowners which in turn allows us to remove gulp-intercept see dominictarr/event-stream#116 for further context * remove loading of gen-codeowners
* name getter * nested test
* clean up docs * analytics * comments * fix dead link
* fix key issues * temp * add dompurifyconfigobject extern * apply recs * fix lint error * make sure __AMP_TOP and __AMP_PARENT don't get obfuscated. these properties are sometimes reached out to in other libraries not compiled in single pass. ex. amp4ads-host, * remove purifier changes. this is reviewed in separate PR
- Check the index of the slide within all slides (rather than all children) as the parent container may contain things other than slides. - Get rid of `div` in the selector, it is overly specific.
No more scroll-bound weirdness!
* Implement maximum-nights feature in range amp-date-picker * Refactor wrapper into wrapper folder * Add validator rules for maximum-nights * Add integration test 🤞 no flakes * Add updated validator test out
* Removes code that forces fixed layout on multi-size slots. * Trivial change to restart travis. * Accidentally re-added code.
* fix key issues * temp * add dompurifyconfigobject extern * apply recs * fix lint error
* Remove ampdoc for getting FIE services. * Remove deprecated service getter. * Remove unused FIE window service getter and inlined helper fn. * Simplify some comments. * Fix test-url-replacements.js. * Fix test-standard-actions.js. * Fix several more tests. * Fix lint. * Fix test-amp-form and test-amp-gwd-animation.
* Hoist templates and ensure duplicates are not added to bundle * Additional test cases for hoisting * Only find program when hoisting * Address PR feedback * Updated to not use branching for html and htmlFor.
* Fix mask appearing on hover. Use patch pattern * Add wildcard patch
…9690) * adding babel plugin for const transformation * adding test for transformer * fixing the is fortesting condition * fixing lints * fixing lints * fixing `is_minified` always true condition * lint fixes * fixing babel transformer * fixes copyrights
* mock window.matchMedia call. * fix test * update comment * address choumx comments * lint
…er depends on `wd` (#19889)
* remove wait for ini-load * expr * fix presubmit * address comment
…19860) * Refeactored consent ui api to match consent response * FInished the consent ui api refactor
* Story supports-landscape attribute validation. * A-Z
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions:
(chore):).ProjectX: Implement some feature).Fixes,Closes, orResolvesfollowed the issue number will automatically close the issue.Example of a good description:
Emojis for categorizing pull requests:
✨ New feature (
:sparkles:)🐛 Bug fix (
:bug:)🔥 P0 fix (
:fire:)✅ Tests (
:white_check_mark:)🚀 Performance improvements (
:rocket:)🖍 CSS / Styling (
:crayon:)♿ Accessibility (
:wheelchair:)🌐 Internationalization (
:globe_with_meridians:)📖 Documentation (
:book:)🏗 Infrastructure / Tooling / Builds / CI (
:building_construction:)⏪ Reverting a previous change (
:rewind:)♻️ Refactoring (like moving around code w/o any changes) (
:recycle:)🚮 Deleting code (
:put_litter_in_its_place:)