Reopen page attachment from browser history. #20292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enriqe
reviewed
Jan 12, 2019
|
|
||
| setHistoryState( | ||
| this.win, | ||
| 'ampStoryAttachmentPageId', |
There was a problem hiding this comment.
Jon would say: here and below, change to enum so we get compilation error instead of silent error in case of a typo :)
There was a problem hiding this comment.
Haha, he would! PTAL
gmajoulet
force-pushed
the
attachment_component_history
branch
from
17f31d2
to
b3bd803
Compare
Enriqe
approved these changes
Jan 14, 2019
gmajoulet
force-pushed
the
attachment_component_history
branch
from
b3bd803
to
af8e462
Compare
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* Reopen attachment from browser history. * Using enum. * Circular dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopen the page attachment if a user clicks on a link that's in it, and comes back.
#20209