✨auto-lightbox carousels under experiment #20910
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,118 @@ | ||
| /** | ||
| * Copyright 2019 The AMP HTML Authors. All Rights Reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS-IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| import {devAssert} from '../../../src/log'; | ||
| import {isActionableByTap} from '../../../src/auto-lightbox'; | ||
| import {isExperimentOn} from '../../../src/experiments'; | ||
| import {iterateCursor} from '../../../src/dom'; | ||
| import {resolveFalse, resolveTrue} from './utils/promise'; | ||
| import {toWin} from '../../../src/types'; | ||
| import {tryResolve} from '../../../src/utils/promise'; | ||
|
|
||
| const MIN_IMG_SLIDE_AREA_RATIO = 0.5; | ||
|
|
||
| export class CarouselCriteria { | ||
| /** | ||
| * @param {!Element} element | ||
| * @return {!Promise<boolean>} | ||
| */ | ||
| static meetsAll(element) { | ||
| const win = toWin(element.ownerDocument.defaultView); | ||
|
|
||
| if (!isExperimentOn(win, 'amp-auto-lightbox-carousel')) { | ||
| return resolveFalse(); | ||
| } | ||
|
|
||
| const slides = element.querySelectorAll('.amp-carousel-slide'); | ||
| const images = element.querySelectorAll('amp-img'); | ||
|
|
||
| if (images.length < 1) { | ||
| return resolveFalse(); | ||
| } | ||
|
|
||
| if (slides.length != images.length) { | ||
| return resolveFalse(); | ||
| } | ||
|
|
||
| let promise = resolveTrue(); | ||
|
|
||
| iterateCursor(slides, slide => { | ||
| promise = promise.then(previousWasAccepted => { | ||
| if (!previousWasAccepted) { | ||
| return false; | ||
| } | ||
| return SlideCriteria.meetsAll(slide); | ||
| }); | ||
| }); | ||
|
|
||
| return promise; | ||
| } | ||
| } | ||
|
|
||
| class SlideCriteria { | ||
|
|
||
| /** | ||
| * @param {!Element} element | ||
| * @return {!Promise<boolean>} | ||
| */ | ||
| static meetsAll(element) { | ||
| if (element.tagName == 'AMP-IMG') { | ||
| return tryResolve(() => !isActionableByTap(element)); | ||
| } | ||
|
|
||
| const img = element.querySelector('amp-img'); | ||
| if (!img) { | ||
| return resolveFalse(); | ||
| } | ||
|
|
||
| const slideMeetsSizingPromise = | ||
| SlideCriteria.meetsSizingCriteria(img, element); | ||
|
|
||
| return slideMeetsSizingPromise.then(slideMeetsSizingCriteria => { | ||
| if (!slideMeetsSizingCriteria) { | ||
| return false; | ||
| } | ||
| return !isActionableByTap(element); | ||
| }); | ||
| } | ||
|
|
||
| /** | ||
| * @param {!AmpElement} img | ||
| * @param {!Element} slide | ||
| * @return {!Promise<boolean>} | ||
| */ | ||
| static meetsSizingCriteria(img, slide) { | ||
| devAssert(img.tagName == 'AMP-IMG'); | ||
|
|
||
| return img.getImpl().then(impl => new Promise(resolve => { | ||
|
There was a problem hiding this comment. I believe return img.getImpl().then(impl => {
return impl.measureElement(() => {
/*...*/
return (imageArea/slideArea >= MIN_IMG_SLIDE_AREA_RATIO);
});
});There was a problem hiding this comment. Unfortunately the measure promise is shared by the entire batch so returning values is not possible. |
||
| impl.measureElement(() => { | ||
| const { | ||
| width: imgWidth, | ||
| height: imgHeight, | ||
| } = img.getLayoutBox(); | ||
|
|
||
| const { | ||
| width: slideWidth, | ||
| height: slideHeight, | ||
| } = slide./*OK*/getBoundingClientRect(); | ||
|
|
||
| const imgArea = imgWidth * imgHeight; | ||
| const slideArea = slideWidth * slideHeight; | ||
|
|
||
| resolve((imgArea / slideArea) >= MIN_IMG_SLIDE_AREA_RATIO); | ||
| }); | ||
| })); | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a race condition since it carousel extension is not loaded yet, we don't have this class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, this runs after
layoutCallback.