Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃寪 Add ability for amp-story-auto-ads CTA strings to be localized #21253

Merged
merged 10 commits into from
Apr 3, 2019
Merged

馃寪 Add ability for amp-story-auto-ads CTA strings to be localized #21253

merged 10 commits into from
Apr 3, 2019

Commits on Apr 2, 2019

  1. Add localized strings for amp-story-auto-ads

    @newmuis
    newmuis committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    61896ad View commit details
    Browse the repository at this point in the history

  2. Update path to localization service

    @newmuis
    newmuis committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    dd00426 View commit details
    Browse the repository at this point in the history

  3. Use localization service to lookup string

    @newmuis
    newmuis committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    d3478ee View commit details
    Browse the repository at this point in the history

  4. Update file paths

    @newmuis
    newmuis committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    0bc6cc7 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2019

  1. Move amp-story-auto-ads strings from amp-story to amp-story-auto-ads

    @newmuis
    newmuis committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    dc7ddc7 View commit details
    Browse the repository at this point in the history

  2. Wrap line

    @newmuis
    newmuis committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    2d73931 View commit details
    Browse the repository at this point in the history

  3. Use same set of languages for amp-story-auto-ads that amp-story is using

    @newmuis
    newmuis committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    60e234b View commit details
    Browse the repository at this point in the history

  4. Update dep check whitelist

    @newmuis
    newmuis committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    efea925 View commit details
    Browse the repository at this point in the history

  5. Remove whitespace

    @newmuis
    newmuis committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    966a9eb View commit details
    Browse the repository at this point in the history

  6. Whitelist amp-story-auto-ads to depend on localization

    @newmuis
    newmuis committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    64909ae View commit details
    Browse the repository at this point in the history