Fix the load-more-button does not display bug #21304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cathyxz
commented
Mar 7, 2019
| this.loadMoreService_.setLoadMoreEnded(); | ||
| } | ||
| }); | ||
| }).then(() => { |
| @@ -79,7 +79,7 @@ | |||
| "items": 8, | |||
| "left": 5, | |||
| "latency": 0, | |||
| "url": "/infinite-scroll?items=8&left=2" | |||
| "url": "/list/infinite-scroll?items=8&left=2" | |||
There was a problem hiding this comment.
Update routes changes due to #21214.
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* Fix sample * Fix urls after routes refactor * Fix load-more-button doesn't display bug * Fix type check
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Mar 22, 2019
* Fix sample * Fix urls after routes refactor * Fix load-more-button doesn't display bug * Fix type check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#20993 caused the regression in #21270. This PR reverts the offending change and unskips the relevant broken e2e tests.
Great catch by our e2e tests. xD