Take amp-list routes out of app.js into its own routing file #21214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cathyxz
requested review from
torch2424,
aghassemi,
dreamofabear and
erwinmombay
and removed request for
torch2424
cathyxz
changed the title
|
Okay I think I have to change some usages of |
aghassemi
approved these changes
Mar 4, 2019
|
/cc owners @erwinmombay @danielrozenberg @rsimha in case any of you would like to take a look. Otherwise this is merging EOD. ;) |
rsimha
approved these changes
Mar 5, 2019
|
Thank you Raghu! |
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
…ect#21214) * Break amp-list routes out into own routing file * Refactor amp-list manual tests and routes out to their own file and folder * Update other usages of enableCors
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Mar 22, 2019
…ect#21214) * Break amp-list routes out into own routing file * Refactor amp-list manual tests and routes out to their own file and folder * Update other usages of enableCors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to add some new routes for another case for amp-list-load-more but
app.jsis > 1k loc. This is a pure refactor PR to take the routes relevant to amp-list out ofapp.jsinto its own routing file. I updated the relevant routes foramp-list.