Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stories animate-in-timing-function parameter validation. #21459

Merged
merged 1 commit into from
Mar 18, 2019
Merged

Stories animate-in-timing-function parameter validation. #21459

merged 1 commit into from
Mar 18, 2019

Conversation

gmajoulet
Copy link
Contributor

Stories animate-in-timing-function parameter validation rules.

It can be used like this:

<p animate-in="fly-in-right" animate-in-duration="600" animate-in-timing-function="linear">
  ...
</p>

@gmajoulet gmajoulet merged commit bcc05c1 into ampproject:master Mar 18, 2019
@honeybadgerdontcare honeybadgerdontcare mentioned this pull request Mar 20, 2019
Merged
Gregable pushed a commit that referenced this pull request Mar 20, 2019
@honeybadgerdontcare @Gregable
Validator roll-up (#21507)
a5f911e 
 - cl/239414441 Revision bump for #21463
 - cl/239234304 Add deprecation warning for manufactured body caused by non-ASCII whitespace.
 - cl/239228383 Explicitly disallow `<template>` outside the document `<body>`.
 - cl/239220081 Add a feature test case for a non-amp document.
 - cl/239050986 Revision bump for #21459
 - cl/239048160 Fix corner case of ancestor marker tracking.
 - cl/238487968 Revision bump for #21107
 - cl/238483735 Revision bump for #21264
noranazmy pushed a commit to noranazmy/amphtml that referenced this pull request Mar 22, 2019
@gmajoulet
Stories animate-in-timing-function parameter validation. (ampproject#…
465f5df 
…21459)
noranazmy pushed a commit to noranazmy/amphtml that referenced this pull request Mar 22, 2019
@honeybadgerdontcare
Validator roll-up (ampproject#21507)
7371f56 
 - cl/239414441 Revision bump for ampproject#21463
 - cl/239234304 Add deprecation warning for manufactured body caused by non-ASCII whitespace.
 - cl/239228383 Explicitly disallow `<template>` outside the document `<body>`.
 - cl/239220081 Add a feature test case for a non-amp document.
 - cl/239050986 Revision bump for ampproject#21459
 - cl/239048160 Fix corner case of ancestor marker tracking.
 - cl/238487968 Revision bump for ampproject#21107
 - cl/238483735 Revision bump for ampproject#21264
bramanudom pushed a commit to bramanudom/amphtml that referenced this pull request Mar 22, 2019
@gmajoulet @bramanudom
Stories animate-in-timing-function parameter validation. (ampproject#…
d6041e1 
…21459)
bramanudom pushed a commit to bramanudom/amphtml that referenced this pull request Mar 22, 2019
@honeybadgerdontcare @bramanudom
Validator roll-up (ampproject#21507)
9b91de9 
 - cl/239414441 Revision bump for ampproject#21463
 - cl/239234304 Add deprecation warning for manufactured body caused by non-ASCII whitespace.
 - cl/239228383 Explicitly disallow `<template>` outside the document `<body>`.
 - cl/239220081 Add a feature test case for a non-amp document.
 - cl/239050986 Revision bump for ampproject#21459
 - cl/239048160 Fix corner case of ancestor marker tracking.
 - cl/238487968 Revision bump for ampproject#21107
 - cl/238483735 Revision bump for ampproject#21264
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gregable Gregable Gregable approved these changes

@Enriqe Enriqe Enriqe approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gmajoulet @Gregable @Enriqe @googlebot @ampprojectbot