Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏗 Change disconnect / no activity timeouts for Sauce Labs #21822

Merged
merged 1 commit into from Apr 11, 2019
Merged

🏗 Change disconnect / no activity timeouts for Sauce Labs #21822

merged 1 commit into from Apr 11, 2019

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Apr 11, 2019 •
edited

We frequently see disconnect failures of this sort on Sauce Labs, even when tests pass:

Safari 12.0.0 (Mac OS X 10.13.6) ERROR
  Disconnected, because no message in 240000 ms.
[15:51:38] Safari 12.0.0 (Mac OS X 10.13.6): Executed 38 of 517 (Skipped 62) SUCCESS
11 04 2019 15:51:38.676:ERROR [reporter.sauce]: ✖ Test Disconnected

Our tests take ~9 minutes for normal execution. This PR increases the values of browserDisconnectTimeout and browserNoActivityTimeout to 10 minutes each so that test runs don't fail if the browser doesn't communicate for that period (Safari in particular is known to stay silent while running tests). Once keepalives are implemented in karma-sauce-launcher, we can reduce these timeouts to the keepalive period. See karma-runner/karma-sauce-launcher#161

Follow up to #21578

@rsimha rsimha self-assigned this Apr 11, 2019
@rsimha rsimha mentioned this pull request Apr 11, 2019
Merged
@rsimha
Copy link
Contributor Author

rsimha commented Apr 11, 2019 •
edited

/to @estherkim @choumx
/cc @joshmgrant

@rsimha
Copy link
Contributor Author

rsimha commented Apr 11, 2019

Looks like this PR worked. Disconnection timeouts have made way for genuine failures, which I will deal with separately. See https://travis-ci.org/ampproject/amphtml/jobs/518863966#L1641. (I've re-run this a couple times with no disconnection timeouts.)

This is ready for review and merge.

@rsimha rsimha merged commit 50d1b90 into ampproject:master Apr 11, 2019
@rsimha rsimha deleted the 2019-04-11-SauceTimeouts branch April 11, 2019 18:00
@dreamofabear
Copy link

Thanks for fixing this!

@rsimha rsimha mentioned this pull request Apr 25, 2019
Merged
@rsimha rsimha mentioned this pull request Jun 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estherkim estherkim estherkim approved these changes

@dreamofabear dreamofabear Awaiting requested review from dreamofabear

Assignees

@rsimha rsimha

Labels
cla: yes Related to: Flaky Tests WG: infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rsimha @dreamofabear @estherkim @googlebot