Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› Fix sauce launcher bug #22824

Merged
merged 5 commits into from Jun 17, 2019
Merged

Conversation

estherkim
Copy link
Collaborator

@estherkim estherkim commented Jun 13, 2019

Remote jobs are failing intermittently due to this error. Not sure why karma-sauce-launcher is attempting to connect to browsers that have already finished running tests. However, updating karma-sauce-launcher to 2.0.2 from 1.2.0 might help as it includes the following fixes thanks to this -
karma-runner/karma-sauce-launcher#156

13 06 2019 00:24:39.631:ERROR [launcher.sauce]: Heartbeat to internet explorer 11.103 (Windows 10) failed
  [title()] Not JSON response
  ERROR The test with session id bcb405a8755f467b9563f20477078b61 has already finished, and can't receive further commands.
You can learn more at https://app.saucelabs.com/tests/bcb405a8755f467b9563f20477078b61
For help, please check https://wiki.saucelabs.com/display/DOCS/Common+Error+Messages
13 06 2019 00:24:39.632:ERROR [karma-server]: {"message":"[title()] Not JSON response","data":"ERROR The test with session id bcb405a8755f467b9563f20477078b61 has already finished, and can't receive further commands.\nYou can learn more at https://app.saucelabs.com/tests/bcb405a8755f467b9563f20477078b61\nFor help, please check https://wiki.saucelabs.com/display/DOCS/Common+Error+Messages"}
(node:7721) [DEP0079] DeprecationWarning: Custom inspection function on Objects via .inspect() is deprecated
[00:24:43] Some tests have failed on beta browsers.
[00:24:43] This is not currently a fatal error, but will become an error once the beta browsers are released as next stable version!
[00:24:43] Shutting down test responses server on localhost:8081
[00:24:43] Finished 'integration' after 5.5 min
13 06 2019 00:32:40.114:ERROR [launcher]: internet explorer 11.103 (Windows 10) on SauceLabs failed 2 times (timeout). Giving up.
IE 11.0.0 (Windows 10.0.0): Executed 1 of 467 (skipped 466) SUCCESS (1.111 secs / 0.506 secs)
TOTAL: 1 SUCCESS
Chrome 75.0.3770 (Windows 10.0.0) ERROR
  Disconnected, because no message in 600000 ms.
[00:34:27] ERROR: Zero tests detected by Karma.
[00:34:27] {"startTime":1560385467174,"total":0,"success":0,"failed":0,"skipped":0,"totalTime":600098,"netTime":0,"error":false,"disconnected":true}
[00:34:27] Chrome 75.0.3770 (Windows 10.0.0): Executed 0 of 0 (Skipped 0) SUCCESS
13 06 2019 00:34:27.275:ERROR [reporter.sauce]: βœ– Test Disconnected

@estherkim estherkim merged commit c99019c into ampproject:master Jun 17, 2019
@rsimha
Copy link
Contributor

rsimha commented Jun 18, 2019

Delayed LGTM.

Some context: We were using v2.0.2 of karma-sauce-launcher in the past. Then, @joshmgrant (from the Sauce labs team) advised us to downgrade to v1.2.0 to solve rampant disconnect errors we were seeing. (See #21578.) Following that, we changed the default disconnect timeout to be longer than test execution time. (See #21822.) I'm not sure if this made #21578 redundant. (Time will tell, I suppose? πŸ˜ƒ)

@estherkim
Copy link
Collaborator Author

Hey @rsimha! Yeah I followed that history before trying this and it was a bit of a whirlwind. But from what I read, the issue @joshmgrant found that recommended downgrading karma-sauce-launcher had to do with Travis builds hanging, which was different from the disconnection problems we saw. And downgrading introduced heartbeat problems as described above, which was fixed in v2.0.2

Hopefully both upgrading and increasing the timeout did the trick, but yep, keeping an eye on Travis.

thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
* remove-selenium

* try upgrade

* yarn lock

* remove wd
@estherkim estherkim deleted the sauce-launcher branch September 16, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants