Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add tracdelight AMP ad integration #22550

Closed
wants to merge 20 commits into from

Conversation

thekorn
Copy link
Contributor

@thekorn thekorn commented May 29, 2019

The pull request contains implementation for the tracdelight ad-widgets for AMP Ads.
Reference to our closed PR is #13956

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@torch2424
Copy link
Contributor

@bhassan6621

Thank you for the contribution! 😄

Please see the intructions given by the CLA bot above if you would like to move forward with this PR 👍

Thank you!

@torch2424 torch2424 self-requested a review June 18, 2019 01:51
@daniel-kuhn-burda
Copy link

Dear reviewer:

  • cla has been signed
  • Travis-ci seems not to failing with this error: 13 Mar 16:12:16 - error querying from https://saucelabs.com/rest/v1/amphtml/tunnels, error was: {"error": "Too many active user tunnels: 5 >= 5"}. HTTP status: 400 Bad Request

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@daniel-kuhn-burda
Copy link

OK by me

@daniel-kuhn-burda
Copy link

@torch2424 can you help us with the CLA message from googleBot (see above)?
All agreements have been signed however we still seem to miss some agreements.
thank you!

@thekorn
Copy link
Contributor Author

thekorn commented Jul 1, 2019

superseeded by #23124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
New Ads Vendor PR
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

4 participants