✨ Add tracdelight AMP ad integration

[thekorn]

The pull request contains implementation for the tracdelight ad-widgets for AMP Ads.
Reference to our closed PRs are #13956 #22550

[mrjoro]

Sorry for the delay in reviewing this @thekorn!

/cc @ampproject/wg-ads

[calebcordry]

@thekorn Thanks for contributing. When I try to run you example locally it doesn't seem to work. Looks like the request to https://api.tracdelight.com/v1/widgets/false/products?accesskey=false might not behave as expected. Would it be possible to return an example ad here? It makes it easier for us to have a working example so that we can ensure we don't break anything etc.

[calebcordry]

Also you might want to rebase since this pr has been out for a while (our fault). I had some weird errors before rebasing. Let me know if you need any assistance.

[thekorn]

thanks @calebcordry for the review, we will look into it and come back to you

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[thekorn]

@calebcordry I've one question: I just pushed one change, and we got flagged cla: no again - altough I'm still the only author in the changeset. What is the reason for this?

[calebcordry]

@thekorn I see that the CLA was approved at one point, but when I look at our internal system it says your username is not registered. What do you see when you follow this link?

[thekorn]

@calebcordry this is what I get on this page:

[calebcordry]

@thekorn in that screenshot I see your @gmail account, but the commits are signed from your @tracdelight account. I think that may be causing the issue. Could you confirm that your tracdelight email is also covered under the corporate CLA? Alternatively you could try changing the author of your commits to be your gmail address and see if that works.

[googlebot]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[calebcordry]

Awesome, looks like you got the CLA all sorted out. I still don't see a working example, did this get lost in the CLA work?

Also, I don't see renderStartImplemented being called. Can you confirm that this is called in your JS? If not you might want to remove it from your config. We suggest implementing it, but if you have the flag as true without implementing, performance is actually worse. Let me know if you need any help. Thanks!

[calebcordry]

nit: 2019

[calebcordry]

Can you change this please?

[thekorn]

@calebcordry done

[calebcordry]

Image of broken ad in case you wanted to see.

[thekorn]

@calebcordry okay, thanks for your feedback - unfortunately the sample widget was not active anymore - I changed the widget id and now it's working properly.

[thekorn]

Hi @calebcordry and @mrjoro
just one question, as a kind of follow up, is there anything needed here from my side? anything I missed?
and what are the next steps here?
thanks for your help

[calebcordry]

nit: 2019

[calebcordry]

Sorry fo the delay. Just the year nits, and this should be ready.

[calebcordry]

Thanks, looks like a travis test flake. I just restarted, I will try to keep an eye on it, but let me know if you see it pass.

[calebcordry]

Passed :) thanks for contributing!