✨ amp-subscriptions-google "smartbox" support #22670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dparikh
approved these changes
Jun 4, 2019
| element.textContent = ''; | ||
| opts.theme = 'light'; | ||
| opts.lang = userAssert( | ||
| element.getAttribute('subscriptions-lang'), |
There was a problem hiding this comment.
in SwG, the attribute name is lang
Gregable
pushed a commit
that referenced
this pull request
Jun 12, 2019
* cl/251742878 Revision bump for #22670 * cl/252092550 Improve validation error message for missing autoplay attribute on amp-carousel.
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
* initial smartbox implementation * lint * smart box * subscriptions-lang attribute * language attrib * remove stray log
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
* cl/251742878 Revision bump for ampproject#22670 * cl/252092550 Improve validation error message for missing autoplay attribute on amp-carousel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preliminary smartbox support, doc to follow when experimat flag is removed from swg.js