馃悰 Report conformance config violations as errors #22914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsimha
approved these changes
Jun 18, 2019
|
I'm hoping there are no errors... 馃槄 |
jridgewell
force-pushed
the
conformanceViolations
branch
from
8628f58
to
5eb9cad
Compare
rsimha
reviewed
Jun 20, 2019
| value: 'DocumentType.prototype.after' | ||
| value: 'CharacterData.prototype.after' | ||
| } | ||
| # TODO(rsimha): Reenable when we move RRule to a node module. |
There was a problem hiding this comment.
@jridgewell I think we need to wait for a closure compiler upgrade before moving to the rrule npm package.
Meanwhile, I've suggested an alternative fix in #22946 (comment)
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
* Report conformance config violations as errors Re: ampproject#22822 (comment) Fixes ampproject#22822 * Fix conformance violations * Temporarily disable Node.p.after ban
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #22822 (comment)
Fixes #22822