🏗 Switch from third_party/rrule to the rrule module

[rsimha]

This PR switches extensions/amp-date-picker/0.1/dates-list.js from third_party/rrule to the rrule module. The aim is to address the TODO in 09eddaa

Follow up to #22914

[rsimha]

I see one new type error: https://travis-ci.org/ampproject/amphtml/jobs/548421199#L1035 I fear this is due to our custom version of closure compiler, and how it does pure imports. If so, this PR might have to wait until google/closure-compiler#3041 is fixed. Edit: Got things to work by suppressing the closure error for pure imports.

@jridgewell Meanwhile, I think you can re-enable the rule for ChildNode.p.after() and whitelist extensions/amp-date-picker/0.1/dates-list.js, similar to ChildNode.p.before() directly above it

amphtml/build-system/conformance-config.textproto

Lines 342 to 350 in 6093a86

	requirement: {
	type: BANNED_PROPERTY_CALL
	error_message: 'ChildNode.p.before() is unusual. Please use Node.p.insertBefore()'
	value: 'Element.prototype.before'
	value: 'DocumentType.prototype.before'
	value: 'CharacterData.prototype.before'
	# It's really hard to properly type check this one.
	whitelist: 'extensions/amp-date-picker/0.1/dates-list.js'
	}

amphtml/build-system/conformance-config.textproto

Lines 352 to 359 in 6093a86

	# TODO(rsimha): Reenable when we move RRule to a node module.
	# requirement: {
	# type: BANNED_PROPERTY_CALL
	# error_message: 'ChildNode.p.after() is unusual. Please use Node.p.insertBefore()'
	# value: 'Element.prototype.after'
	# value: 'DocumentType.prototype.after'
	# value: 'CharacterData.prototype.after'
	# }

[rsimha]

Got type checks and tests to work by rolling back to rrule v2.2.0, the version originally checked in to third_party/, which also removes the unnecessary dependency on luxon.

This PR is ready for another review.

[cvializ]

LGTM

[jridgewell]

@rsimha Is it possible to drop the conformance config exceptions with this change?

[rsimha]

@rsimha Is it possible to drop the conformance config exceptions with this change?

I just tried, and am seeing these two conformance violations:

extensions/amp-date-picker/0.1/dates-list.js:83: ERROR - Possible violation: ChildNode.p.after() is unusual. Please use Node.p.insertBefore()
The type information available for this expression is too loose to ensure conformance.
      .map(rrule => rrule.after(date))
                    ^^^^^^^^^^^

extensions/amp-date-picker/0.1/dates-list.js:113: ERROR - Possible violation: ChildNode.p.before() is unusual. Please use Node.p.insertBefore()
The type information available for this expression is too loose to ensure conformance.
      const rruleDay = this.moment_(rrule.before(nextDate));
                                    ^^^^^^^^^^^^

I think this can be fixed by providing type info for this.rrulestrs_. @cvializ, do you know what the type is supposed to be?

[jridgewell]

They should be RRule types.

[rsimha]

In that case, we're likely going to have to wait until google/closure-compiler#3041 is fixed, which will allow us to use the {Array<RRule>} type annotation for this.rrulestrs_. Until then, we'll see this error.

extensions/amp-date-picker/0.1/dates-list.js:43: ERROR - Bad type annotation. Unknown type RRule
    /** @private @const {Array<RRule>} */
                               ^

Importing RRule from the rrule module yields this slightly different error:

extensions/amp-date-picker/0.1/dates-list.js:43: ERROR - Bad type annotation. Unknown type RRule$$module$rrule
    /** @private @const {Array<RRule>} */
                               ^

[rsimha]

I tried a different thing: casting the rrule param to RRule, and got these errors:

extensions/amp-date-picker/0.1/dates-list.js:83: ERROR - Property after never defined on rrule
      .map((/** {RRule} */ rrule) => rrule.after(date))
                                           ^^^^^

extensions/amp-date-picker/0.1/dates-list.js:113: ERROR - Property before never defined on rrule
      const rruleDay = this.moment_(rrule.before(nextDate));
                                          ^^^^^^

[rsimha]

The missing ingredient was an entry in the externs file. Done in #23001.