🏗🚮 Remove workaround to transform Common JS modules to ESM #23106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a previous closure compiler upgrade (#18794), we had to apply a workaround to transform a few modules used by the AMP runtime from Common JS to ESM. This was needed because single pass compilation was broken by the closure flag
process_common_js_modules
.The workaround is no longer necessary because all three modules now have ESM equivalents, and we no longer need to transform them.
This PR does the following:
dompurify
: Already using ESMpromise-pjs
: Switched from v1.1.3 to v1.1.4, which supports ESMset-dom
: Changed usage from Common JS to ESMsingle-pass.js
andbuild.conf.js
that has to do with Common JS -> ESM transformationbabel-plugin-transform-commonjs-es2015-modules
Addresses #18794 (review)