New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Make sure rrule
code is included in amp-date-picker
#23113
Conversation
@jridgewell @cvializ I had to skip one unit test that appears to be failing now that Meanwhile, I've confirmed that the |
I think the failing test might be a sign of broken behavior and not a flake. I'll take a look |
I think this is the breaking change: the RRULE methods return values as local time formatted as a UTC date : / This is a breaking change you'd expect them to bump the major version for, not the minor. |
Nice catch. I've removed the commit that skips a test from this PR, so all that's left to do now is fix the existing tests, and manually test the component to make sure it works, and all the code is included. |
@cvializ I tested this with your commit included, and verified that:
This is now ready for review and merge once Travis goes green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for your help!
In #22946, we switched
rrule
from a copy inthird_party
to an installed module. However, we neglected to add an entry for the module in the directories included in the runtime.This PR fixes things so that the
rrule
code is included indist/v0/amp-date-picker-0.1.js
.It will likely have to be cherry-picked to canary before next week's prod push.Edit: None of the currently released versions are affected by this issue. This fix will make it into the next canary and prod releases.