✅ TEST: createElement instead of insertAdjacentHTML #23454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `defaultValue` property returns "the default value as originally specified in the HTML that created this object." https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement#Properties Test elements for `isFieldDefault` were originally created with `insertAdjacentHTML` to ensure their `defaultValue` properties is generated correctly. It turns out `setAttribute` actually modifies the element's HTML definition, and thus could update the `defaultValue` property. This change migrates the test to use the preferred `createElement` and `setAttribute` to set up test elements.
|
Code looks good, consider arrange the description in a way like: "what we are changing": "why we are changing": "references": |
cvializ
approved these changes
Jul 23, 2019
rindo
pushed a commit
to logly/amphtml
that referenced
this pull request
Jul 24, 2019
The `defaultValue` property returns "the default value as originally specified in the HTML that created this object." https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement#Properties Test elements for `isFieldDefault` were originally created with `insertAdjacentHTML` to ensure their `defaultValue` properties is generated correctly. It turns out `setAttribute` actually modifies the element's HTML definition, and thus could update the `defaultValue` property. This change migrates the test to use the preferred `createElement` and `setAttribute` to set up test elements.
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
The `defaultValue` property returns "the default value as originally specified in the HTML that created this object." https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement#Properties Test elements for `isFieldDefault` were originally created with `insertAdjacentHTML` to ensure their `defaultValue` properties is generated correctly. It turns out `setAttribute` actually modifies the element's HTML definition, and thus could update the `defaultValue` property. This change migrates the test to use the preferred `createElement` and `setAttribute` to set up test elements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change migrates the test to use the preferred
createElementandsetAttributeto set up test elements.Test elements for
isFieldDefaultwere originally created withinsertAdjacentHTMLto ensure theirdefaultValue(*) properties aregenerated correctly. It turns out
setAttributeactually modifies theelement's HTML definition, and thus could update the
defaultValueproperty.
* The
defaultValueproperty returns "the default value as originallyspecified in the HTML that created this object."
https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement#Properties
Follow-up for #22541 (comment), related to #22534.
/cc @GoTcWang, @cvializ thanks!