Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ TEST: createElement instead of insertAdjacentHTML #23454

Merged
merged 1 commit into from
Jul 23, 2019

Commits on Jul 22, 2019

  1. TEST: createElement instead of insertAdjacentHTML

    The `defaultValue` property returns "the default value as originally
    specified in the HTML that created this object."
    https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement#Properties
    
    Test elements for `isFieldDefault` were originally created with
    `insertAdjacentHTML` to ensure their `defaultValue` properties is
    generated correctly. It turns out `setAttribute` actually modifies the
    element's HTML definition, and thus could update the `defaultValue`
    property.
    
    This change migrates the test to use the preferred `createElement` and
    `setAttribute` to set up test elements.
    xrav3nz committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    a56c066 View commit details
    Browse the repository at this point in the history