🏗 Fix detection for failure to generateRunner #24084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsimha
reviewed
Aug 20, 2019
rsimha
reviewed
Aug 20, 2019
westonruter
force-pushed
the
fix/java-failure-detection
branch
from
9bbcea1
to
e737ac9
Compare
rsimha
approved these changes
Aug 20, 2019
westonruter
force-pushed
the
fix/java-failure-detection
branch
from
e737ac9
to
dbf4fdd
Compare
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
generateRunner()it currently is detecting for an error for runningantby checking for the responsestderr. This turns out to not always work. When Java is not installed, then the onlystdoutis populated. The proper way to detect for an error is to check the exit code. This PR does that, as well as add a link to where instructions can be found to install Java as required.