🐛 Experiment for fixing height inconsistency between 3p and a4a paths for AdSense ads #24174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lannka Could you PTAL? |
riklund
force-pushed
the
height
branch
3 times, most recently
from
eed35b8
to
4a0c975
Compare
|
This pull request introduces 1 alert when merging 4a0c975 into d1077e3 - view on LGTM.com new alerts:
|
riklund
force-pushed
the
height
branch
2 times, most recently
from
31f46b1
to
c8f3c7e
Compare
lannka
approved these changes
Sep 4, 2019
|
@keithwrightbos PTAL |
keithwrightbos
approved these changes
Sep 5, 2019
extensions/amp-ad-network-adsense-impl/0.1/amp-ad-network-adsense-impl.js
Outdated
Show resolved
Hide resolved
…selection for AdSense responsive AMP ads. See also ampproject#24166. Tested locally and verified that we got a new height with the experiment enabled.
keithwrightbos
approved these changes
Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #24166.