Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ANALYTICS_VENDOR_SPLIT expiry back one month #24415

Merged
merged 1 commit into from Sep 9, 2019

Conversation

dreamofabear
Copy link

Fixes master.

/home/travis/build/ampproject/amphtml/build-system/build.conf.js:94
        throw new Error(
        ^
Error: experimentA has expired on Sun, 08 Sep 2019 00:00:00 GMT. Please remove from experiments-config.json and cleanup relevant code.

https://travis-ci.org/ampproject/amphtml/jobs/582527777

This was last broken a month ago in #23809. @zhouyx Are these expiry dates arbitrary? If so, we should pick a further date that doesn't break next month.

@lannka lannka merged commit ec9a2b9 into master Sep 9, 2019
@rsimha rsimha deleted the fix-experiment-expired branch September 17, 2019 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants