New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Callout vendor update: adding gdpr_consent and account to Prebid Server urls #24620
Conversation
Prebid Server now supports taking the gdpr_consent parameter on the AMP endpoint. The assumption I'm making here is that the consent string is available to callout vendors as ATTR(consentString) - @zhouyx, can you confirm? This is based on info from https://github.com/ampproject/amphtml/blob/master/extensions/amp-consent/integrating-consent.md
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@@ -60,13 +60,13 @@ const RTC_VENDORS = jsonConfiguration({ | |||
}, | |||
prebidappnexus: { | |||
url: | |||
'https://prebid.adnxs.com/pbs/v1/openrtb2/amp?tag_id=PLACEMENT_ID&w=ATTR(width)&h=ATTR(height)&ow=ATTR(data-override-width)&oh=ATTR(data-override-height)&ms=ATTR(data-multi-size)&slot=ATTR(data-slot)&targeting=TGT&curl=CANONICAL_URL&timeout=TIMEOUT&adcid=ADCID&purl=HREF', | |||
'https://prebid.adnxs.com/pbs/v1/openrtb2/amp?tag_id=PLACEMENT_ID&w=ATTR(width)&h=ATTR(height)&ow=ATTR(data-override-width)&oh=ATTR(data-override-height)&ms=ATTR(data-multi-size)&slot=ATTR(data-slot)&targeting=TGT&curl=CANONICAL_URL&timeout=TIMEOUT&adcid=ADCID&purl=HREF&gdpr_consent=ATTR(consentString)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The macro is CONSENT_STRING
.
Please also include the CONSENT_STRING
to the macros
declaration below. Thanks.
You can refer the usage here for an example.
amphtml/extensions/amp-a4a/0.1/callout-vendors.js
Lines 116 to 128 in 5309266
criteo: { | |
url: | |
'https://bidder.criteo.com/amp/rtc?zid=ZONE_ID&nid=NETWORK_ID&psubid=PUBLISHER_SUB_ID&lir=LINE_ITEM_RANGES&w=ATTR(width)&h=ATTR(height)&ow=ATTR(data-override-width)&oh=ATTR(data-override-height)&ms=ATTR(data-multi-size)&slot=ATTR(data-slot)&timeout=TIMEOUT&curl=CANONICAL_URL&href=HREF&cst=CONSENT_STATE&cst_str=CONSENT_STRING', | |
macros: [ | |
'ZONE_ID', | |
'NETWORK_ID', | |
'PUBLISHER_SUB_ID', | |
'LINE_ITEM_RANGES', | |
'CONSENT_STATE', | |
'CONSENT_STRING', | |
], | |
disableKeyAppend: true, | |
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - fixed.
Working on getting Rubicon to sign the CLA. |
Tests succeeded on Chrome, Safari, IE, Firefox, failed on Windows 10. Since I just added a parameter to the end of a URL, am suspecting that it's a test environment issue like we experience over on Prebid sometimes. Once I get the CLA issue sorted out, will ask for a re-build. |
Thanks @bretg Let me know when the CLA is ready. Looks like a flaky test, I've tried rebuild. |
@googlebot I signed it! |
1 similar comment
@googlebot I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Ok @zhouyx - CLA's done. Note that I also added 'ACCOUNT' to the URL, so am requesting re-review. |
Looks great. PR merged! |
thanks @zhouyx Question about AMP GDPR. The other Prebid interfaces accept an optional GDPR in-scope flag from the CMP. Does the AMP CMP have the ability to pass whether the current user is considered in-scope for GDPR? https://iabtechlab.com/wp-content/uploads/2018/02/OpenRTB_Advisory_GDPR_2018-02.pdf
I don't believe this is the same as AMP's |
Thanks for the feedback. I am assuming that in the case where a consent_string is presented, the CMP indicates that the user is in the EEA. If not, the CMP has the full control of the consent string, is it common use case to include the bit to the head of the consent string? As you mentioned, consentStateValue is not designed for this use case. Could you please give me an example? If this is a common use case, we are always open to introduce a new variable to indicate GDPR in-scope flag. Thanks. |
Hi @zhouyx , Trust you're well mate. When is this due for release? - we're helping confirm this is working as expected in PROD. Cheers, |
Hello Adam, Thank you for reaching out. The change shipped with this release https://github.com/ampproject/amphtml/releases. Regarding the release date, it is always one week after the change lives in canary. |
Adds the gdpr_consent and account parameters to Rubicon and AppNexus Prebid Server RTC vendor entries