New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃悰Update Ooyala player version from Sandbox to Prod #24738
Conversation
The Ooyala player iframe version currently used is at https://player.ooyala.com/static/v4/sandbox/amp_iframe/skin-plugin/amp_iframe.html which is using the player version 4.10.6 Our current production version is at v4.32.8. This update will solve some customer issues with analytics and provide them with a more recent and stable player
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 馃摑 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
鈩癸笍 Googlers: Go here for more info. |
Hey @alanorozco, these files were changed:
Hey @wassgha, these files were changed:
Hey @ampproject/wg-caching, these files were changed:
|
@googlebot I signed it! |
Updating the Ooyala player version to /production/latest
Update Ooyala player version from Sandbox to Prod Latest in 'amp-ooyala-player/0.1/tests'
Updating embedcode, pcode and playerid to use active values and be able to have playback with a test video.
@googlebot I signed it! |
@googlebot I signed it! |
@googlebot I signed it! |
@wassgha I see that it did not pass the Travis CI verification. Is something else that requires to be updated? Seeing the following warning:
|
Hey! You need to run |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. 鈩癸笍 Googlers: Go here for more info. |
@googlebot I fixed it. |
1 similar comment
@googlebot I fixed it. |
CLAs look good, thanks! 鈩癸笍 Googlers: Go here for more info. |
@wassgha Hi! I just want to confirm if something is still missing since the merging is still blocked for me. Is this only can be done by authorized users? Thank you! |
Once #24828 lands, the owners check on PRs like this would pass. Merging for now. |
The Ooyala player iframe version currently used is at https://player.ooyala.com/static/v4/sandbox/amp_iframe/skin-plugin/amp_iframe.html which is using the player version 4.10.6
Our current production version is at v4.32.8. This update will solve some customer issues with analytics and provide them with a more recent and stable player.