Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰Update Ooyala player version from Sandbox to Prod #24738

Merged
merged 5 commits into from Oct 2, 2019

Conversation

bc-vescoto
Copy link
Contributor

The Ooyala player iframe version currently used is at https://player.ooyala.com/static/v4/sandbox/amp_iframe/skin-plugin/amp_iframe.html which is using the player version 4.10.6

Our current production version is at v4.32.8. This update will solve some customer issues with analytics and provide them with a more recent and stable player.

The Ooyala player iframe version currently used is at https://player.ooyala.com/static/v4/sandbox/amp_iframe/skin-plugin/amp_iframe.html which is using the player version 4.10.6

Our current production version is at v4.32.8. This update will solve some customer issues with analytics and provide them with a more recent and stable player
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

馃摑 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

鈩癸笍 Googlers: Go here for more info.

@amp-owners-bot
Copy link

amp-owners-bot bot commented Sep 25, 2019

Hey @alanorozco, these files were changed:

  • extensions/amp-ooyala-player/0.1/amp-ooyala-player.js

Hey @wassgha, these files were changed:

  • extensions/amp-ooyala-player/0.1/amp-ooyala-player.js

Hey @ampproject/wg-caching, these files were changed:

  • extensions/amp-ooyala-player/0.1/test/validator-amp-ooyala.html

@bc-vescoto
Copy link
Contributor Author

@googlebot I signed it!

@wassgha wassgha self-requested a review September 25, 2019 21:42
Updating the Ooyala player version to /production/latest
Update Ooyala player version from Sandbox to Prod Latest in 'amp-ooyala-player/0.1/tests'
Updating embedcode, pcode and playerid to use active values and be able to have playback with a test video.
@bc-vescoto
Copy link
Contributor Author

@googlebot I signed it!

@bc-vescoto
Copy link
Contributor Author

@googlebot I signed it!

@googlebot I signed it!

@bc-vescoto
Copy link
Contributor Author

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

馃摑 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

鈩癸笍 Googlers: Go here for more info.

@googlebot I signed it!

@bc-vescoto
Copy link
Contributor Author

@wassgha I see that it did not pass the Travis CI verification. Is something else that requires to be updated?

Seeing the following warning:

DeprecationWarning: assert.fail() with more than one argument is deprecated. Please use assert.strictEqual() instead or only pass a message.

ValidatorFeatures amp-ooyala-player/0.1/test/validator-amp-ooyala.html Message: AssertionError [ERR_ASSERTION]: amp-ooyala-player/0.1/test/validator-amp-ooyala.out:1:0

@wassgha
Copy link
Contributor

wassgha commented Sep 27, 2019

@wassgha I see that it did not pass the Travis CI verification. Is something else that requires to be updated?

Seeing the following warning:

DeprecationWarning: assert.fail() with more than one argument is deprecated. Please use assert.strictEqual() instead or only pass a message.

ValidatorFeatures amp-ooyala-player/0.1/test/validator-amp-ooyala.html Message: AssertionError [ERR_ASSERTION]: amp-ooyala-player/0.1/test/validator-amp-ooyala.out:1:0

Hey! You need to run gulp validator --update_tests in order to update the output of the validator test you changed to match the changes you made. Once the .out file is updated, please commit and push it :)

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

鈩癸笍 Googlers: Go here for more info.

@bc-vescoto
Copy link
Contributor Author

@googlebot I fixed it.

1 similar comment
@bc-vescoto
Copy link
Contributor Author

@googlebot I fixed it.

@googlebot
Copy link

CLAs look good, thanks!

鈩癸笍 Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Oct 1, 2019
@bc-vescoto
Copy link
Contributor Author

@wassgha Hi! I just want to confirm if something is still missing since the merging is still blocked for me. Is this only can be done by authorized users? Thank you!

@wassgha
Copy link
Contributor

wassgha commented Oct 2, 2019

Once #24828 lands, the owners check on PRs like this would pass. Merging for now.

@wassgha wassgha merged commit 39a14b1 into ampproject:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants