Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰Update Ooyala player version from Sandbox to Prod #24738

Merged
merged 5 commits into from
Oct 2, 2019
Merged

馃悰Update Ooyala player version from Sandbox to Prod #24738

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6496946
Update Ooyala player version from Sandbox to Prod
bc-vescoto Sep 25, 2019
bcfb978
Updating the Ooyala player version to /production/latest
bc-vescoto Sep 25, 2019
53c56e0
Update Ooyala player version from Sandbox to Prod Latest
bc-vescoto Sep 25, 2019
dac5cd5
Updating embedcode, pcode and playerid
bc-vescoto Sep 26, 2019
ccb0bd6
Adding validator .out
bc-vescoto Sep 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions/amp-ooyala-player/0.1/amp-ooyala-player.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ class AmpOoyalaPlayer extends AMP.BaseElement {
const playerVersion = el.getAttribute('data-playerversion') || '';
if (playerVersion.toLowerCase() == 'v4') {
src =
'https://player.ooyala.com/static/v4/sandbox/amp_iframe/' +
'https://player.ooyala.com/static/v4/production/latest/' +
'skin-plugin/amp_iframe.html?pcode=' +
encodeURIComponent(this.pCode_);
const configUrl = el.getAttribute('data-config');
Expand Down
4 changes: 2 additions & 2 deletions extensions/amp-ooyala-player/0.1/test/test-amp-ooyala.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ describes.realWin(
const playerIframe = player.querySelector('iframe');
expect(playerIframe).to.not.be.null;
expect(playerIframe.src).to.equal(
'https://player.ooyala.com/static/v4/sandbox/' +
'amp_iframe/skin-plugin/amp_iframe.html' +
'https://player.ooyala.com/static/v4/production/latest/' +
'skin-plugin/amp_iframe.html' +
'?pcode=5zb2wxOlZcNCe_HVT3a6cawW298X' +
'&ec=Vxc2k0MDE6Y_C7J5podo3UDxlFxGaZrQ' +
'&pbid=6440813504804d76ba35c8c787a4b33c'
Expand Down
24 changes: 12 additions & 12 deletions extensions/amp-ooyala-player/0.1/test/validator-amp-ooyala.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,43 +32,43 @@
<amp-ooyala-player
height=400
width=400
data-embedcode="xkeHRiMjE6ls2aXoPoiqmPO6IU8HtXsg"
data-pcode="5zb2wxOlZcNCe_HVT3a6cawW298X"
data-playerid="26e2e3c1049c4e70ae08a242638b5c40"
data-embedcode="93eGs5MDE6dQ-pp527TpHmaFz4zuU9aX"
data-pcode="p0cW46sbRY1PxXueRVL2a_4BfdFz"
data-playerid="a19658a7198f4cffb745bf2062551f9b"
data-playerversion="v4">
</amp-ooyala-player>

<!-- valid, uses V3 player by default -->
<amp-ooyala-player
height=400
width=400
data-embedcode="xkeHRiMjE6ls2aXoPoiqmPO6IU8HtXsg"
data-pcode="5zb2wxOlZcNCe_HVT3a6cawW298X"
data-playerid="26e2e3c1049c4e70ae08a242638b5c40">
data-embedcode="93eGs5MDE6dQ-pp527TpHmaFz4zuU9aX"
data-pcode="p0cW46sbRY1PxXueRVL2a_4BfdFz"
data-playerid="a19658a7198f4cffb745bf2062551f9b">
</amp-ooyala-player>

<!-- invalid, needs data-pcode -->
<amp-ooyala-player
height=400
width=400
data-embedcode="xkeHRiMjE6ls2aXoPoiqmPO6IU8HtXsg"
data-playerid="26e2e3c1049c4e70ae08a242638b5c40">
data-embedcode="93eGs5MDE6dQ-pp527TpHmaFz4zuU9aX"
data-playerid="a19658a7198f4cffb745bf2062551f9b">
</amp-ooyala-player>

<!-- invalid, needs data-embedcode -->
<amp-ooyala-player
height=400
width=400
data-pcode="5zb2wxOlZcNCe_HVT3a6cawW298X"
data-playerid="26e2e3c1049c4e70ae08a242638b5c40">
data-pcode="p0cW46sbRY1PxXueRVL2a_4BfdFz"
data-playerid="a19658a7198f4cffb745bf2062551f9b">
</amp-ooyala-player>

<!-- invalid, needs data-playerid -->
<amp-ooyala-player
height=400
width=400
data-embedcode="xkeHRiMjE6ls2aXoPoiqmPO6IU8HtXsg"
data-pcode="5zb2wxOlZcNCe_HVT3a6cawW298X">
data-embedcode="93eGs5MDE6dQ-pp527TpHmaFz4zuU9aX"
data-pcode="p0cW46sbRY1PxXueRVL2a_4BfdFz">
</amp-ooyala-player>
</body>
</html>