migrate @babel/preset-env to babel-preset-modules #24780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristoferbaxter
suggested changes
Sep 27, 2019
| @@ -36,8 +36,8 @@ exports.transpileTs = function(srcDir, srcFilename) { | |||
| const tsEntry = path.join(srcDir, srcFilename).replace(/\.js$/, '.ts'); | |||
| const tsConfig = ts.convertCompilerOptionsFromJson( | |||
| { | |||
| 'module': 'ES6', | |||
| 'target': 'ES6', | |||
| 'module': 'esnext', | |||
erwinmombay
changed the title
erwinmombay
force-pushed
the
modern-preset
branch
from
bf322ad
to
1eca3ed
Compare
kristoferbaxter
approved these changes
Sep 27, 2019
rsimha
reviewed
Oct 1, 2019
| @@ -256,7 +256,7 @@ function compile(entryModuleFilenames, outputDir, outputFilename, options) { | |||
| assume_function_wrapper: true, | |||
| // Transpile from ES6 to ES5 if not running with `--esm` | |||
| // otherwise transpilation is done by Babel | |||
There was a problem hiding this comment.
Does this comment need to be updated?
| @@ -20,6 +20,7 @@ | |||
| "dependencies": { | |||
| "@ampproject/animations": "0.2.0", | |||
| "@ampproject/worker-dom": "0.19.0", | |||
| "babel-preset-modules": "0.0.2", | |||
There was a problem hiding this comment.
Should @babel/preset-env have been removed from package.json?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.