馃悰Add CSS rule to hide amp-loaders from stories #24895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparhami
approved these changes
Oct 8, 2019
|
@jackbsteinberg can you rebase your PR to trigger a new OWNERS check? |
jackbsteinberg
force-pushed
the
loader-class
branch
from
aa5b09d
to
4d5c40f
Compare
newmuis
approved these changes
Oct 14, 2019
jackbsteinberg
force-pushed
the
loader-class
branch
from
4622690
to
ac1a1a1
Compare
joshuarrrr
pushed a commit
to Parsely/amphtml
that referenced
this pull request
Oct 22, 2019
* Add CSS rule to hide old loaders from stories * Change loader blocking rule to important
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
* Add CSS rule to hide old loaders from stories * Change loader blocking rule to important
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a rule to ignore amp-active divs on amp-stories to prevent the outdated loader from displaying.
Resolves #24609