Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update css/ OWNERS #24960

Merged
merged 1 commit into from Oct 8, 2019
Merged

Update css/ OWNERS #24960

merged 1 commit into from Oct 8, 2019

Conversation

gmajoulet
Copy link
Contributor

Update css/ OWNERS

cc @aghassemi @camelburrito @jackbsteinberg

@rcebulko
Copy link
Contributor

rcebulko commented Oct 8, 2019

Syntax and all looks fine, please get approval from one of the original owners (I terhnically own OWNERS files for monitoring/syntax checking reasons but I don't have authority to actually approve ownership changes)

@kristoferbaxter kristoferbaxter removed the request for review from camelburrito October 8, 2019 20:50
@aghassemi
Copy link
Contributor

LGTM 👋😢

@gmajoulet
Copy link
Contributor Author

You're still on it Ali! :))

@gmajoulet gmajoulet merged commit 7f7650d into ampproject:master Oct 8, 2019
@gmajoulet gmajoulet deleted the css_owners branch October 8, 2019 21:52
Comment on lines +8 to +9
{ name: 'aghassemi' },
{ name: 'camelburrito' },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delayed drive-by comment: We should probably add requestReviews: false to these two lines so that @aghassemi and @camelburrito are not auto-assigned as reviewers. I'll do this in #24971.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good looking out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants