Set @alanorozco and @wassgha as owners of video service #24908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcebulko
reviewed
Oct 4, 2019
There was a problem hiding this comment.
Aside from the comment, LGTM from a syntax perspective. Please get owners approval from an owner of src or one of the subdirectories; I'm only an owner for the purposes of monitoring owners syntax and best practices, but do not have authority to approve actual changes in ownership.
JSON format
kristoferbaxter
approved these changes
Oct 17, 2019
|
@kristoferbaxter I'm consistently setting this OWNER set for video-related files as not to spam the rest of |
alanorozco
added a commit
that referenced
this pull request
Oct 18, 2019
Realized that video service files are really touched when creating 3p player contributions, so they can be set to the broader ampproject/wg-ui-and-a11y group (rather than the specific set from #24908). Added missing ownership for other video/media related files in src.
jeffjose
pushed a commit
to jeffjose/amphtml
that referenced
this pull request
Oct 19, 2019
jeffjose
pushed a commit
to jeffjose/amphtml
that referenced
this pull request
Oct 19, 2019
Realized that video service files are really touched when creating 3p player contributions, so they can be set to the broader ampproject/wg-ui-and-a11y group (rather than the specific set from ampproject#24908). Added missing ownership for other video/media related files in src.
joshuarrrr
pushed a commit
to Parsely/amphtml
that referenced
this pull request
Oct 22, 2019
joshuarrrr
pushed a commit
to Parsely/amphtml
that referenced
this pull request
Oct 22, 2019
Realized that video service files are really touched when creating 3p player contributions, so they can be set to the broader ampproject/wg-ui-and-a11y group (rather than the specific set from ampproject#24908). Added missing ownership for other video/media related files in src.
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
Realized that video service files are really touched when creating 3p player contributions, so they can be set to the broader ampproject/wg-ui-and-a11y group (rather than the specific set from ampproject#24908). Added missing ownership for other video/media related files in src.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.