OWNERS set for video files in src #25120
Conversation
|
Hey @rcebulko, these files were changed:
|
| { | ||
| rules: [ | ||
| { | ||
| pattern: 'video-*.js', |
There was a problem hiding this comment.
Should we move these files into the src/service/video/ folder? The fewer filename patterns the better.
IMO this is a good chance to start massaging our source dir structure into something more sane. Also it would enable semantically grouped subfolder README.md files.
There was a problem hiding this comment.
Some aren't strictly for the service but rather utilities for component implementations.
I agree with the sentiment, though. How about just src/video? Maybe we can move the service implementation into that dir as well.
I'm going to go ahead merging this to unblock another PR but I'll restructure later. Thanks for the suggestions.
There was a problem hiding this comment.
We do have a convention that service classes (objects shared across multiple binaries) are in src/service/ e.g. our linter bans direct imports.
We can change this -- just pointing it out.
| @@ -6,5 +6,9 @@ | |||
| { | |||
| owners: [{name: 'dvoytenko'}, {name: 'ampproject/wg-runtime'}], | |||
| }, | |||
| { | |||
| pattern: '{iframe-video,mediasession-helper,video-*}.js', | |||
Realized that video service files are really touched when creating 3p player contributions, so they can be set to the broader ampproject/wg-ui-and-a11y group (rather than the specific set from ampproject#24908). Added missing ownership for other video/media related files in src.
Realized that video service files are really touched when creating 3p player contributions, so they can be set to the broader ampproject/wg-ui-and-a11y group (rather than the specific set from ampproject#24908). Added missing ownership for other video/media related files in src.
Realized that video service files are really touched when creating 3p player contributions, so they can be set to the broader ampproject/wg-ui-and-a11y group (rather than the specific set from ampproject#24908). Added missing ownership for other video/media related files in src.
Realized that video service files are really touched when creating 3p player contributions, so they can be set to the broader
ampproject/wg-ui-and-a11ygroup (rather than the specific set from #24908).Added missing ownership for other video/media related files in
src.