馃悰loader: Disable caching of LoaderService Promise #24939
Conversation
In a PWA, the loaderServicePromise cannot be reused across page navigations; style[amp-extension="amp-loader"] is lost. Add a dispose method to reset the promise when shadowDoc.close() runs.
|
/CC: @sparhami |
|
Hmm, I think we should just remove all the caching of the Promise, and just return it directly. the functions for installing the extension and getting the service short circuit fairly quickly anyway. |
|
Also, I think on dispose is not quite the right thing, since you could have two shadow AMP documents active at once. |
|
Thanks for the feedback!
Ok, I'm happy to give this a go. I also recognize I hijacked this issue from you and am ok if you want to take it over. I just got curious how the loader integrates and wanted to dig in a bit.
Really? Is this a reality or a hope for someday in the future? Last I tried several months ago, this was not possible. I'll be really excited if two AMP docs can coexist without detrimental cross-talk. |
Feel free to continue on this change if you have time. If you don't, I can send out a PR.
I think with amp-next-page it can have multiple shadow docs on the page at once. I'm no sure what bugs might come up as a result. I haven't looked into it for a while though. |
This reverts commit 7253153.
Cached LoaderService becomes invalid on page transition in a PWA. Rely on .installExtensionForDoc() to short-circuit quickly when the service is already available and to install the doc extension when needed.
mattwomple
changed the title
|
@choumx Can you approve this PR for the owners check? |
Cached LoaderService becomes invalid on page transition in a PWA. Rely
on .installExtensionForDoc() to short-circuit quickly when the service
is already available and to install the doc extension when needed.
Fixes #24740