Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰loader: Disable caching of LoaderService Promise #24939

Merged
merged 4 commits into from
Oct 8, 2019
Merged

馃悰loader: Disable caching of LoaderService Promise #24939

merged 4 commits into from
Oct 8, 2019

Commits on Oct 7, 2019

  1. loader: Add dispose method

    In a PWA, the loaderServicePromise cannot be reused across page
    navigations; style[amp-extension="amp-loader"] is lost. Add a dispose
    method to reset the promise when shadowDoc.close() runs.
    mattwomple committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    7253153 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2019

  1. Configuration menu
    Copy the full SHA
    5ebd6a3 View commit details
    Browse the repository at this point in the history
  2. Revert "loader: Add dispose method"

    This reverts commit 7253153.
    mattwomple committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    ac02120 View commit details
    Browse the repository at this point in the history
  3. loader: Disable caching of LoaderService Promise

    Cached LoaderService becomes invalid on page transition in a PWA. Rely
    on .installExtensionForDoc() to short-circuit quickly when the service
    is already available and to install the doc extension when needed.
    mattwomple committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    d0eb260 View commit details
    Browse the repository at this point in the history