New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏗 Add OWNERS
files for all build-system/
sub-directories
#24945
Conversation
I've populated all these |
I like mine, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the strategy of adding a team and notifying specific users!
}, | ||
{ | ||
pattern: 'internal-version.js', | ||
owners: [{ name: 'danielrozenberg', notify: true }] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You edit a file ONCE… 😅
{ | ||
owners: [ | ||
{ name: 'ampproject/wg-infra' }, | ||
{ name: 'rsimha', notify: true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add me here as a notify too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already merged. Can you add in a new PR?
Hey @alanorozco, these files were changed:
|
This PR adds
OWNERS
files acrossbuild-system/
./cc @ampproject/wg-infra @ampproject/wg-runtime @ampproject/wg-performance since there's some common code that everyone must be able to edit.