Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗 Add OWNERS files for all build-system/ sub-directories #24945

Merged
merged 1 commit into from
Oct 8, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 16 additions & 0 deletions build-system/babel-plugins/OWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
// For an explanation of the OWNERS rules and syntax, see:
// https://github.com/ampproject/amp-github-apps/blob/master/owners/OWNERS.example

{
rules: [
{
owners: [
{ name: 'ampproject/wg-infra' },
{ name: 'ampproject/wg-runtime' },
{ name: 'ampproject/wg-performance' },
{ name: 'erwinmombay', notify: true },
{ name: 'jridgewell', notify: true }
]
}
]
}
10 changes: 10 additions & 0 deletions build-system/common/OWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
// For an explanation of the OWNERS rules and syntax, see:
// https://github.com/ampproject/amp-github-apps/blob/master/owners/OWNERS.example

{
rules: [
{
owners: [{ name: 'ampproject/wg-infra' }]
}
]
}
33 changes: 33 additions & 0 deletions build-system/compile/OWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
// For an explanation of the OWNERS rules and syntax, see:
// https://github.com/ampproject/amp-github-apps/blob/master/owners/OWNERS.example

{
rules: [
{
owners: [{ name: 'ampproject/wg-infra' }]
},
{
pattern: '{build.conf,bundles.config,sources}.js',
owners: [
{ name: 'ampproject/wg-infra' },
{ name: 'ampproject/wg-runtime' },
{ name: 'ampproject/wg-performance' }
]
},
{
pattern: '{closure-compile,compile}.js',
owners: [{ name: 'rsimha', notify: true }]
},
{
pattern: 'single-pass.js',
owners: [
{ name: 'erwinmombay', notify: true },
{ name: 'rsimha', notify: true }
]
},
{
pattern: 'internal-version.js',
owners: [{ name: 'danielrozenberg', notify: true }]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You edit a file ONCE… 😅

}
]
}
16 changes: 16 additions & 0 deletions build-system/eslint-rules/OWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
// For an explanation of the OWNERS rules and syntax, see:
// https://github.com/ampproject/amp-github-apps/blob/master/owners/OWNERS.example

{
rules: [
{
owners: [
{ name: 'ampproject/wg-infra' },
{ name: 'ampproject/wg-runtime' },
{ name: 'ampproject/wg-performance' },
{ name: 'erwinmombay', notify: true },
{ name: 'jridgewell', notify: true }
]
}
]
}
10 changes: 10 additions & 0 deletions build-system/externs/OWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
// For an explanation of the OWNERS rules and syntax, see:
// https://github.com/ampproject/amp-github-apps/blob/master/owners/OWNERS.example

{
rules: [
{
owners: [{ name: '*' }]
}
]
}
14 changes: 14 additions & 0 deletions build-system/pr-check/OWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// For an explanation of the OWNERS rules and syntax, see:
// https://github.com/ampproject/amp-github-apps/blob/master/owners/OWNERS.example

{
rules: [
{
owners: [
{ name: 'ampproject/wg-infra' },
{ name: 'estherkim', notify: true },
{ name: 'rsimha', notify: true }
]
}
]
}
14 changes: 14 additions & 0 deletions build-system/runner/OWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// For an explanation of the OWNERS rules and syntax, see:
// https://github.com/ampproject/amp-github-apps/blob/master/owners/OWNERS.example

{
rules: [
{
owners: [
{ name: 'ampproject/wg-infra' },
{ name: 'erwinmombay', notify: true },
{ name: 'rsimha', notify: true }
]
}
]
}
13 changes: 13 additions & 0 deletions build-system/sauce_connect/OWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
// For an explanation of the OWNERS rules and syntax, see:
// https://github.com/ampproject/amp-github-apps/blob/master/owners/OWNERS.example

{
rules: [
{
owners: [
{ name: 'ampproject/wg-infra' },
{ name: 'rsimha', notify: true }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add me here as a notify too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already merged. Can you add in a new PR?

]
}
]
}
14 changes: 14 additions & 0 deletions build-system/server/OWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// For an explanation of the OWNERS rules and syntax, see:
// https://github.com/ampproject/amp-github-apps/blob/master/owners/OWNERS.example

{
rules: [
{
owners: [{ name: 'ampproject/wg-infra' }]
},
{
pattern: 'lazy-build.js',
owners: [{ name: 'rsimha', notify: true }]
}
]
}
13 changes: 13 additions & 0 deletions build-system/server/app-index/OWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
// For an explanation of the OWNERS rules and syntax, see:
// https://github.com/ampproject/amp-github-apps/blob/master/owners/OWNERS.example

{
rules: [
{
owners: [
{ name: 'ampproject/wg-infra' },
{ name: 'alanorozco', notify: true }
]
}
]
}
10 changes: 10 additions & 0 deletions build-system/tasks/OWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
// For an explanation of the OWNERS rules and syntax, see:
// https://github.com/ampproject/amp-github-apps/blob/master/owners/OWNERS.example

{
rules: [
{
owners: [{ name: 'ampproject/wg-infra' }]
}
]
}
13 changes: 13 additions & 0 deletions build-system/tasks/e2e/OWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
// For an explanation of the OWNERS rules and syntax, see:
// https://github.com/ampproject/amp-github-apps/blob/master/owners/OWNERS.example

{
rules: [
{
owners: [
{ name: 'ampproject/wg-infra' },
{ name: 'estherkim', notify: true }
]
}
]
}
13 changes: 13 additions & 0 deletions build-system/tasks/runtime-test/OWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
// For an explanation of the OWNERS rules and syntax, see:
// https://github.com/ampproject/amp-github-apps/blob/master/owners/OWNERS.example

{
rules: [
{
owners: [
{ name: 'ampproject/wg-infra' },
{ name: 'estherkim', notify: true }
]
}
]
}
13 changes: 13 additions & 0 deletions build-system/tasks/visual-diff/OWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
// For an explanation of the OWNERS rules and syntax, see:
// https://github.com/ampproject/amp-github-apps/blob/master/owners/OWNERS.example

{
rules: [
{
owners: [
{ name: 'ampproject/wg-infra' },
{ name: 'danielrozenberg', notify: true }
]
}
]
}
18 changes: 18 additions & 0 deletions build-system/test-configs/OWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
// For an explanation of the OWNERS rules and syntax, see:
// https://github.com/ampproject/amp-github-apps/blob/master/owners/OWNERS.example

{
rules: [
{
owners: [
{ name: 'ampproject/wg-infra' },
{ name: 'ampproject/wg-runtime' },
{ name: 'ampproject/wg-performance' }
]
},
{
pattern: 'dep-check-config.js',
owners: [{ name: '*' }]
}
]
}