Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add Empower to amp-ad networks #24949

Merged
merged 1 commit into from Oct 16, 2019

Conversation

merty
Copy link
Contributor

@merty merty commented Oct 8, 2019

We would like our global ad network and video monetization platform, Empower to be one of the supported networks for the amp-ad component.

@zhouyx zhouyx requested review from calebcordry and removed request for zhouyx October 8, 2019 22:57
Copy link
Member

@calebcordry calebcordry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, just a few small questions.

examples/ads.amp.html Show resolved Hide resolved
ads/empower.md Show resolved Hide resolved
@calebcordry
Copy link
Member

to/ @honeybadgerdontcare for validator changes

Copy link
Contributor

@honeybadgerdontcare honeybadgerdontcare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validation looks good

@calebcordry calebcordry merged commit 3e6457f into ampproject:master Oct 16, 2019
@calebcordry
Copy link
Member

@merty Thanks for contributing!

@merty merty deleted the add-empower-to-amp-ad branch October 17, 2019 06:01
@Gregable Gregable mentioned this pull request Oct 18, 2019
Gregable pushed a commit that referenced this pull request Oct 18, 2019
* cl/275100411 Revision bump for #24773

* cl/275345662 Revision bump for #24949

* cl/275491856 Remove ErrorCategories in the AMP Validator.

* Small integration updates to files not tracked by validator rollups to
match the changes in the ErrorCategories commit.
jeffjose pushed a commit to jeffjose/amphtml that referenced this pull request Oct 19, 2019
* cl/275100411 Revision bump for ampproject#24773

* cl/275345662 Revision bump for ampproject#24949

* cl/275491856 Remove ErrorCategories in the AMP Validator.

* Small integration updates to files not tracked by validator rollups to
match the changes in the ErrorCategories commit.
joshuarrrr pushed a commit to Parsely/amphtml that referenced this pull request Oct 22, 2019
joshuarrrr pushed a commit to Parsely/amphtml that referenced this pull request Oct 22, 2019
* cl/275100411 Revision bump for ampproject#24773

* cl/275345662 Revision bump for ampproject#24949

* cl/275491856 Remove ErrorCategories in the AMP Validator.

* Small integration updates to files not tracked by validator rollups to
match the changes in the ErrorCategories commit.
micajuine-ho pushed a commit to micajuine-ho/amphtml that referenced this pull request Dec 27, 2019
micajuine-ho pushed a commit to micajuine-ho/amphtml that referenced this pull request Dec 27, 2019
* cl/275100411 Revision bump for ampproject#24773

* cl/275345662 Revision bump for ampproject#24949

* cl/275491856 Remove ErrorCategories in the AMP Validator.

* Small integration updates to files not tracked by validator rollups to
match the changes in the ErrorCategories commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants