New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add Empower to amp-ad networks #24949
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merty
force-pushed
the
add-empower-to-amp-ad
branch
from
October 8, 2019 13:17
4d062b6
to
a04d68a
Compare
calebcordry
reviewed
Oct 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing, just a few small questions.
merty
force-pushed
the
add-empower-to-amp-ad
branch
from
October 15, 2019 07:04
a04d68a
to
1eb7f88
Compare
merty
force-pushed
the
add-empower-to-amp-ad
branch
from
October 15, 2019 19:59
1eb7f88
to
81f5128
Compare
calebcordry
approved these changes
Oct 15, 2019
to/ @honeybadgerdontcare for validator changes |
honeybadgerdontcare
approved these changes
Oct 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
validation looks good
@merty Thanks for contributing! |
Merged
Gregable
pushed a commit
that referenced
this pull request
Oct 18, 2019
jeffjose
pushed a commit
to jeffjose/amphtml
that referenced
this pull request
Oct 19, 2019
* cl/275100411 Revision bump for ampproject#24773 * cl/275345662 Revision bump for ampproject#24949 * cl/275491856 Remove ErrorCategories in the AMP Validator. * Small integration updates to files not tracked by validator rollups to match the changes in the ErrorCategories commit.
joshuarrrr
pushed a commit
to Parsely/amphtml
that referenced
this pull request
Oct 22, 2019
joshuarrrr
pushed a commit
to Parsely/amphtml
that referenced
this pull request
Oct 22, 2019
* cl/275100411 Revision bump for ampproject#24773 * cl/275345662 Revision bump for ampproject#24949 * cl/275491856 Remove ErrorCategories in the AMP Validator. * Small integration updates to files not tracked by validator rollups to match the changes in the ErrorCategories commit.
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
* cl/275100411 Revision bump for ampproject#24773 * cl/275345662 Revision bump for ampproject#24949 * cl/275491856 Remove ErrorCategories in the AMP Validator. * Small integration updates to files not tracked by validator rollups to match the changes in the ErrorCategories commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like our global ad network and video monetization platform, Empower to be one of the supported networks for the amp-ad component.